Adds preservation of newlines between statements in formatter #405
+69
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -414,6 +414,7 @@ export class TreePrintVisitor extends CypherCmdParserVisitor<void> { | |||
| this.currentBuffer().pop(); | |||
| } | |||
| this.visit(ctx.SEMICOLON(i)); | |||
| this.preserveExplicitNewlineAfter(ctx.SEMICOLON(i)); | |||
There was a problem hiding this comment.
Will the semicolon still be visited?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #382 added preservation of explicit newlines, but only between different clauses. As a result, in queries like:
the blank line after
a;is removed. This PR allows preserving newlines between statements, so that users can separate statements with a blank line.Testing
4 new simple tests for statements with newlines after them